Skip to content

Conversation

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Feb 3, 2025

  • Single-choice (radio buttons): Gray out price when not selected + show price on closed dropdown
  • Multi-choice: Show correct per-unit price + gray out price when not selected

fixes #6728

@ThiefMaster ThiefMaster added this to the v3.3 milestone Feb 3, 2025
@ThiefMaster
Copy link
Member Author

@foxbunny I noticed that the new Select field in the single-choice field shows the price label only when the dropdown is open, but not for the currently selected value:

image
image

I think before we always showed it, which IMHO makes sense because when looking at the form you should always see the prices of your choices.

When using "extra slots" this is not really a problem since we show the total, but without it we rely on the label of the option being visible. But I think in both cases it'd be nicer to have the label:

image

@foxbunny
Copy link
Collaborator

foxbunny commented Feb 3, 2025

Ok, I'll take a look.

@foxbunny
Copy link
Collaborator

foxbunny commented Feb 4, 2025

Try this version: foxbunny@3e9b425

@ThiefMaster
Copy link
Member Author

Almost what I'm looking for! There's just some weird overlap with the clear button now:

image

@foxbunny
Copy link
Collaborator

foxbunny commented Feb 4, 2025

Fixed. Try this: foxbunny@87eedfd

@ThiefMaster ThiefMaster enabled auto-merge (squash) February 4, 2025 08:47
@ThiefMaster
Copy link
Member Author

ty, looks good!

@ThiefMaster ThiefMaster merged commit 186c18d into indico:master Feb 4, 2025
10 checks passed
@ThiefMaster ThiefMaster deleted the reg-fix-price-display branch February 4, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple choice field with price and extra slots displays wrong information

2 participants