Add length validation to sign-up form fields #6724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Feb 5, 2025
| syncedValues={syncedValues} | ||
| lockedFields={lockedFields} | ||
| lockedFieldMessage={lockedFieldMessage} | ||
| validate={value => value !== undefined && v.maxLength(250)(value)} |
Member
There was a problem hiding this comment.
why not return early in maxLength if the value is undefined?
Contributor
Author
There was a problem hiding this comment.
Because none of the validators deals with the undefined value.
However I noticed it causes issue when the form is loaded the first time. Only for not required fields. Adding this check here solved the problem but I'm not confident it's the best approach.
ThiefMaster
force-pushed
the
add_length_validation_to_sign_up_form_fields
branch
from
4d9a601 to
dda5911
Compare
ThiefMaster
force-pushed
the
add_length_validation_to_sign_up_form_fields
branch
from
dda5911 to
c426be4
Compare
ThiefMaster
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding length validation to fields on registration and user profile forms to prevent abusing and sending garbage data to the application.
The following fields have got length validation: