Skip to content

Add option to enforce search before adding person #6689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 9 commits into from
Feb 14, 2025
Merged

Add option to enforce search before adding person #6689

ThiefMaster merged 9 commits into from
Feb 14, 2025

Conversation

@duartegalvao
Copy link
Member

@duartegalvao duartegalvao commented Jan 9, 2025 •
edited
Loading

This PR adds an option to hide the *Enter manually" button while still allowing custom persons to be entered from the search dialog.

Changes:

  • Replaced the "Disallow custom persons" event setting with "Enforce user search"
    image
  • Added a button to enter manually when user search returns empty results
    image
  • Added a signal to set required fields for the "Enter person" dialog
    image

@duartegalvao duartegalvao mentioned this pull request Jan 9, 2025
Merged
@duartegalvao duartegalvao force-pushed the enter-manually-from-search branch 3 times, most recently from 94a08e5 to b7c47e0 Compare January 9, 2025 13:45
@github-actions github-actions bot added the alembic Contains database changes label Jan 10, 2025
@tomasr8 tomasr8 self-requested a review January 10, 2025 15:43
ThiefMaster
ThiefMaster reviewed Jan 10, 2025
View reviewed changes
@duartegalvao duartegalvao force-pushed the enter-manually-from-search branch from 3ba69af to a6923b2 Compare January 13, 2025 16:59
tomasr8
tomasr8 reviewed Jan 14, 2025
View reviewed changes
@duartegalvao duartegalvao force-pushed the enter-manually-from-search branch from a6923b2 to 2d39f20 Compare January 14, 2025 10:27
@duartegalvao duartegalvao requested a review from tomasr8 January 14, 2025 10:27
@duartegalvao duartegalvao force-pushed the enter-manually-from-search branch from 2d39f20 to cebf48f Compare January 30, 2025 13:36
@duartegalvao duartegalvao force-pushed the enter-manually-from-search branch from cebf48f to 7bc3070 Compare February 11, 2025 13:14
@ThiefMaster ThiefMaster force-pushed the enter-manually-from-search branch from 7bc3070 to 8bf3e1d Compare February 12, 2025 11:31
ThiefMaster
ThiefMaster reviewed Feb 13, 2025
View reviewed changes
@ThiefMaster ThiefMaster enabled auto-merge (squash) February 14, 2025 12:40
@ThiefMaster ThiefMaster added this to the v3.3 milestone Feb 14, 2025
@ThiefMaster ThiefMaster merged commit ffd4033 into indico:master Feb 14, 2025
10 checks passed
@ThiefMaster ThiefMaster deleted the enter-manually-from-search branch February 14, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

@tomasr8 tomasr8 Awaiting requested review from tomasr8

Assignees

No one assigned

Labels

alembic Contains database changes

Projects

JACoW suggestions to Indico
Status: Done 🚀

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@duartegalvao @ThiefMaster @tomasr8