Encode event name text in share widget #6649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GovernmentPlates
force-pushed
the
encode-share-text
branch
from
967af32 to
f8ee022
Compare
tomasr8
reviewed
Dec 4, 2024
GovernmentPlates
force-pushed
the
encode-share-text
branch
from
f8ee022 to
e7ea914
Compare
ThiefMaster
force-pushed
the
encode-share-text
branch
from
e7ea914 to
517e727
Compare
ThiefMaster
approved these changes
Dec 9, 2024
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Dec 19, 2024
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Jan 7, 2025
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where event names with special characters (e.g.
&,#etc.) would break the share url for Mastodon and Twitter.