Fail gracefully on invalid session timezone #6647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
force-pushed
the
invalid-timezone
branch
from
3c8edd4 to
0a3afdb
Compare
tomasr8
reviewed
Dec 4, 2024
This can happen when a user has has bad timezone data in the DB, typically the case for very old users from times (no pun intended) where we did not properly validate changes to the user's preferred timezone. Also memoize session timezone utils, since they get called A LOT when generating the timezone picker...
It was always set to true anyway...
ThiefMaster
force-pushed
the
invalid-timezone
branch
from
0a3afdb to
9de8b14
Compare
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Dec 19, 2024
* Fail gracefully on invalid session timezone This can happen when a user has has bad timezone data in the DB, typically the case for very old users from times (no pun intended) where we did not properly validate changes to the user's preferred timezone. Also memoize session timezone utils, since they get called A LOT when generating the timezone picker... * Get rid of `as_timezone` arg It was always set to true anyway...
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Jan 7, 2025
* Fail gracefully on invalid session timezone This can happen when a user has has bad timezone data in the DB, typically the case for very old users from times (no pun intended) where we did not properly validate changes to the user's preferred timezone. Also memoize session timezone utils, since they get called A LOT when generating the timezone picker... * Get rid of `as_timezone` arg It was always set to true anyway...
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Jan 7, 2025
* Fail gracefully on invalid session timezone This can happen when a user has has bad timezone data in the DB, typically the case for very old users from times (no pun intended) where we did not properly validate changes to the user's preferred timezone. Also memoize session timezone utils, since they get called A LOT when generating the timezone picker... * Get rid of `as_timezone` arg It was always set to true anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when a user has has bad timezone data in the DB, typically the case for very old users from times (no pun intended) where we did not properly validate changes to the user's preferred timezone.
(It would of course be nicer to automatically discard such garbage data, but making any changes in that util feels extremely wrong. I will just fix invalid timezones in out DB manually.)
Also memoize session timezone utils, since they get called A LOT when generating the timezone picker...