Allow overriding custom meeting themes #6622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
force-pushed
the
theme-override
branch
from
cec4c9b to
82f73bf
Compare
- Populate event user setting defaults as well - Assign `False` if the event user setting is disabled This allows to have themes where those theme settings are set explicitly, and the event user setting can be used to override the setting to "off".
ThiefMaster
approved these changes
Nov 28, 2024
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Dec 19, 2024
Co-authored-by: Adrian Moennich <[email protected]>
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Jan 7, 2025
Co-authored-by: Adrian Moennich <[email protected]>
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Jan 7, 2025
Co-authored-by: Adrian Moennich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding the inline and numbered notes settings from
themes.yaml.These settings are available on the Layout page:
For example if inline minutes is toggled, the meeting minutes will always render expanded even if the theme's default is different.
The settings are only visible for themes that explicitly allow the settings to be overridden. This can be done by extending the
user_settingswith eitheruser_setting_inline_minutes,user_setting_numbered_contributionsor both: