Include tags in editable list #6615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Nov 13, 2024
Member
There was a problem hiding this comment.
I like it! I just have some nitpicks;
I'm not a huge fan of that indicator tbh :/
It feels a bit too "heavy", especially compared to the text ellipses we have in other columns. Maybe it could be a bit less prominent?
I'd also add some vertical gap to the tooltip tags:
Could also be nice to sort the tags, the order seems to change with every page refresh
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
qa-status-editable-list
branch
2 times, most recently
from
1315303 to
952c975
Compare
tomasr8
reviewed
Jan 22, 2025
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.module.scss
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
qa-status-editable-list
branch
from
7ce0722 to
4d03741
Compare
micsucmed
force-pushed
the
qa-status-editable-list
branch
from
4d03741 to
023a6c6
Compare
ThiefMaster
force-pushed
the
qa-status-editable-list
branch
2 times, most recently
from
765bfca to
0889ae1
Compare
ThiefMaster
reviewed
Mar 27, 2025
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
Member
|
I think this was nearly done besides the stuff from my last review... maybe worth reviving so it can be merged soon? :) |
micsucmed
force-pushed
the
qa-status-editable-list
branch
from
0889ae1 to
7660e07
Compare
Contributor
Author
|
I forgot about this PR, sorry. I just finished up correcting the latest comments. |
tomasr8
approved these changes
Jul 30, 2025
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
qa-status-editable-list
branch
from
3931f42 to
52c0e83
Compare
micsucmed
force-pushed
the
qa-status-editable-list
branch
from
52c0e83 to
80d1983
Compare
Refining ui tags class name
It doesn't do anything useful...
ThiefMaster
force-pushed
the
qa-status-editable-list
branch
from
80d1983 to
db6ad22
Compare
ThiefMaster
force-pushed
the
qa-status-editable-list
branch
from
13bf06c to
2ab3a1e
Compare
It contains the same data as what's already in the cell
ThiefMaster
force-pushed
the
qa-status-editable-list
branch
from
7c1ee9f to
943cf7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a column to include the editable tags if any exist
closes #6614