Use fixed positioning instead of absolute #6588
Conversation
foxbunny
commented
Oct 28, 2024
foxbunny
commented
- Improves positioning in tricky layouts in exchange for a performance hit
- Adds a placeholder selector for adding positioning properties to the target element
foxbunny
force-pushed
the
fixed-position
branch
from
bf3705b to
aa059fd
Compare
|
This is an extracted and improved (in terms of code style) version of the updated positioning logic in the dual date picker PR. I need this for another PR I'm working on. |
- Improves positioning in tricky layouts in exchange for a performance hit - Adds a placeholder selector for adding positioning properties to the target element
ThiefMaster
force-pushed
the
fixed-position
branch
from
aa059fd to
439ec09
Compare
| window.addEventListener( | ||
| 'resize', | ||
| () => { | ||
| strategy.resetGeometry(adjustPosition); |
There was a problem hiding this comment.
Shouldn't this be debounced? Running an event handler on resize cause a pretty high amount of events if you actually resize the window (and not just move e.g. between normal and maximized).
There was a problem hiding this comment.
Technically it would need to be throttled, not debounced. But it's probably optimizing for an edge case to degrade the experience for the primary case where you are dealing with one-time screen rotate, maximize-minimize type of events.
|
There's a small regression which I think comes from this PR:
When the Dropdown moves upwards instead of downwards, the upper border is hidden - which makes sense when opening downwards, but looks weird when when opening upwards. |
2 participants
