Refactor positioning logic #6577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
foxbunny
commented
Oct 10, 2024
foxbunny
commented
- Move positioning logic from TipBase into positioning module
- Create a system for specifying various positioning strategies
foxbunny
force-pushed
the
position-refactor
branch
from
0ae82c9 to
442caab
Compare
Collaborator
Author
|
@ThiefMaster I've worked out how I'd handle the positioning of the date range picker last night. I'll need this patch so I don't have to redo it twice. Can you please review this? |
- Move positioning logic from TipBase into positioning module - Create a system for specifying various positioning strategies
I know it works, but it looks weird...
ThiefMaster
force-pushed
the
position-refactor
branch
from
442caab to
09ab8fe
Compare
ThiefMaster
approved these changes
Oct 16, 2024
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
nice one! just fixed a typo and some minor stylistic things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.