Ensure event logo takes all page content width #6572
Conversation
OmeGak
force-pushed
the
fix/event-logo-size
branch
2 times, most recently
from
86d326b to
0bd790e
Compare
tomasr8
left a comment
tomasr8
left a comment
There was a problem hiding this comment.
Thanks, looks much better now!
|
How likely is this to cause problems w/ existing conferences, especially ones using custom CSS? |
If the custom CSS uses |
|
That's what worries me a bit... I think we have to test on our side with a bunch of existing conferences that have a custom stylesheet which contains any selectors likely related to the logo |
|
Just tested this, and whilst it seems to be fine with our custom stylesheets that we have on the CERN instance, the change does cause small logos to be stretched out:
A good alternative (suggested by @ThiefMaster) for this would be to add an option that would allow users to show the event logo as a banner; by selecting this option, we would use different CSS styles that would be more suitable for showing this as a banner. That way, we don't break old events (as well as save time for people no longer having to write custom CSS styles for banner-like logos). |
OmeGak
force-pushed
the
fix/event-logo-size
branch
2 times, most recently
from
6ac3827 to
345916c
Compare
|
Added a new "Use logo as banner" switch in the Header Style settings section. Enabling it activates the new CSS, leaving it disabled uses the previous CSS. 
|
OmeGak
force-pushed
the
fix/event-logo-size
branch
from
345916c to
0981e2d
Compare
OmeGak
force-pushed
the
fix/event-logo-size
branch
3 times, most recently
from
ee06c4b to
4b87153
Compare
|
Just wondering, do we really want to scale an image up or can we prevent that while still making it look as banner-like as possible w/ its size? Otherwise an event organizer might upload something that's a bit too small and not even notice that it gets blurrier than it should be. Mentioning the recommended width of a banner logo on the layout management page might also be useful. |
OmeGak
force-pushed
the
fix/event-logo-size
branch
5 times, most recently
from
52f914b to
f291841
Compare
|
I added flashed warnings when:
These warnings appear both when:
|
OmeGak
force-pushed
the
fix/event-logo-size
branch
from
f291841 to
001118f
Compare
We do not show the label anywhere but it feels cleaner to have it set nonetheless. If we want to ditch labels for that field, it should be done in all places wher that particular field is used.
4 participants
This PR makes sure that event logos take the entire width of the page content while preserving form factor. In particular, it solves issues when the event logo's width is lesser and greater than the content page's width.