Disallow mixing invited rules with other rules #6567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GovernmentPlates
force-pushed
the
disallow-invites
branch
from
34d5d90 to
671f731
Compare
Member
|
LGTM so far! I think it'd be nice to also have validation that ensures the |
ThiefMaster
reviewed
Oct 8, 2024
GovernmentPlates
force-pushed
the
disallow-invites
branch
from
73a4e05 to
93acef5
Compare
ThiefMaster
force-pushed
the
disallow-invites
branch
from
93acef5 to
bd1e85f
Compare
ThiefMaster
force-pushed
the
disallow-invites
branch
from
bd1e85f to
b2e1b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes a bug where by attempting to use the 'invited' state rule with other rules (in the CfA module) would throw a route builder error (as the
{invitation_url}wouldn't exist in the invited state).Closes: #6563