Skip to content

Conversation

@SegiNyn
Copy link
Contributor

@SegiNyn SegiNyn commented Oct 1, 2024

This pr is to add a permissions at the location-level in the RB to determine who can manage it and giving access to the Location part of the RB.

@github-actions github-actions bot added the alembic Contains database changes label Oct 1, 2024
@SegiNyn SegiNyn marked this pull request as ready for review October 7, 2024 09:06
@SegiNyn SegiNyn force-pushed the add-location-manager branch 3 times, most recently from ae5b407 to 49adb1a Compare January 22, 2025 17:03
@SegiNyn SegiNyn changed the title Add location management permission Add location manager role Jan 27, 2025
@ThiefMaster ThiefMaster force-pushed the add-location-manager branch from 49adb1a to 49fba84 Compare March 5, 2025 14:57
@ThiefMaster ThiefMaster force-pushed the add-location-manager branch from 5db14cd to 1e353c9 Compare March 5, 2025 16:07
@SegiNyn SegiNyn force-pushed the add-location-manager branch from 622ce6f to f2f5041 Compare March 6, 2025 15:23
@SegiNyn
Copy link
Contributor Author

SegiNyn commented Mar 6, 2025

Hello @ThiefMaster,

I've updated the PR to allow permissions assigned to the location manager (prebook, book, moderate) to be applicable to the rooms in the location. And if the manage permission is assigned then the location manager will be able to see a new section "My locations" where they can further manage rooms
Screenshot 2025-03-06 at 16 34 23

@ThiefMaster ThiefMaster force-pushed the add-location-manager branch from f2f5041 to a84ae62 Compare March 6, 2025 17:09
@ThiefMaster ThiefMaster added this to the v3.3 milestone Mar 7, 2025
@ThiefMaster ThiefMaster force-pushed the add-location-manager branch from 7f8b1a7 to f752e2c Compare March 7, 2025 17:00
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice pr! :)

@ThiefMaster ThiefMaster merged commit 8072e45 into indico:master Mar 7, 2025
10 checks passed
@ThiefMaster ThiefMaster deleted the add-location-manager branch March 7, 2025 17:13
SegiNyn added a commit to UNOG-Indico/indico-core that referenced this pull request Mar 10, 2025
Add new Location ACL, and allow location managers to manage their
location and its rooms without being RB admins.

Co-authored-by: Adrian Moennich <[email protected]>
OmeGak pushed a commit to UNOG-Indico/indico-core that referenced this pull request Mar 12, 2025
Add new Location ACL, and allow location managers to manage their
location and its rooms without being RB admins.

Co-authored-by: Adrian Moennich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alembic Contains database changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants