-
Notifications
You must be signed in to change notification settings - Fork 510
Show preview of registration email #6560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Sep 25, 2024
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Sep 25, 2024
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ThiefMaster ready for another round! |
ThiefMaster
reviewed
Oct 21, 2024
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/templates/management/regform_edit.html
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/templates/management/regform_edit.html
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/templates/management/regform_edit.html
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ThiefMaster ready for another round! |
18eb75d to
0b06fec
Compare
Member
|
I included some data in the preview since it looks weird if it's missing. At least on my side the PR is good to go now, but maybe you want to have a last look at my latest additions? |
7fd7ed4 to
2a2879d
Compare
ThiefMaster
approved these changes
Nov 6, 2024
2a2879d to
0e801bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the user to display a preview of the registration emails that would be sent. More details can be found in #6539.
Screenshots
Closes #6539.