Enforce browser caching in send_file() for event logos etc.
#6559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Sep 24, 2024
ThiefMaster
reviewed
Sep 25, 2024
ThiefMaster
reviewed
Sep 25, 2024
GovernmentPlates
force-pushed
the
cache-logos
branch
from
237ec50 to
56d3f7e
Compare
ThiefMaster
approved these changes
Oct 14, 2024
ThiefMaster
force-pushed
the
cache-logos
branch
from
56d3f7e to
0949f66
Compare
ThiefMaster
changed the title
send_file()send_file() for event logos etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
send_file()method to send amax_agecache control header, so that content (e.g. images - such as large event logos etc.) is properly cached in the browser.Closes: #6555