Revamp and generate PDF timetable using Weasyprint #6558

AjobK · 2024-09-23T13:05:00Z

Closes #6554

ThiefMaster

I know it's still WIP, just a few comments on things I noticed while skimming over the diff

indico/modules/events/timetable/templates/pdf/_toc.html

indico/modules/events/timetable/templates/pdf/timetable.css

indico/modules/events/timetable/controllers/display.py

AjobK · 2024-09-24T13:29:48Z

I will get to the comments after the refactor as some of this might not be relevant anymore. However, I'll keep the points in mind for the new code and will check these things when the PoC is done.

indico/modules/events/timetable/templates/pdf/_program.html

AjobK · 2024-10-25T09:10:29Z

As discussed with @ThiefMaster , we will remove the old code and logic once the current changes are approved.

AjobK · 2024-10-25T09:23:23Z

Example of generated PDF for large event (350 pages) with everything displayed and only the 'each session on new page' flag disabled:

ICHEP 2024 example

indico/modules/events/timetable/templates/pdf/_program.html

indico/modules/events/timetable/templates/pdf/timetable.html

indico/modules/events/timetable/templates/pdf/_program.html

indico/modules/events/timetable/templates/pdf/timetable.html

indico/modules/events/timetable/templates/pdf/_program.html

indico/modules/events/timetable/templates/pdf/_toc.html

indico/modules/events/timetable/controllers/display.py

AjobK · 2024-11-01T09:55:29Z

@tomasr8 @ThiefMaster

I have modified the code so that the old PDF export is easy to remove. Use the PDF button for the new PDF generation, and the PDF (Legacy) button for the old generation. When this PR is approved I will simply remove all the code associated with the old PDF.

indico/modules/events/timetable/templates/display/indico/_subcontribution.html

indico/modules/events/timetable/templates/pdf/_program.html

indico/modules/events/timetable/templates/pdf/_toc.html

indico/modules/events/timetable/templates/pdf/timetable.html

indico/modules/events/timetable/templates/pdf/_program.html

This option feels way too noisy to be enabled there...

It was literally the same for static pages and the live endpoint

ThiefMaster

everything works nicely now :)

AjobK marked this pull request as draft September 23, 2024 13:05

ThiefMaster changed the title ~~Draft: Pdf timetable~~ Generate PDF timetable using Weasyprint Sep 23, 2024

ThiefMaster reviewed Sep 23, 2024

View reviewed changes

ThiefMaster reviewed Oct 11, 2024

View reviewed changes

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

AjobK force-pushed the pdf-timetable branch from e9ef223 to b13957f Compare October 17, 2024 14:06

AjobK marked this pull request as ready for review October 25, 2024 09:02

AjobK requested review from ThiefMaster and tomasr8 October 25, 2024 09:02

AjobK force-pushed the pdf-timetable branch from 7552fb9 to ae6661e Compare October 25, 2024 09:07

AjobK changed the title ~~Generate PDF timetable using Weasyprint~~ Revamp and generate PDF timetable using Weasyprint Oct 25, 2024

ThiefMaster reviewed Oct 25, 2024

View reviewed changes

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

AjobK requested a review from ThiefMaster October 25, 2024 13:36

AjobK force-pushed the pdf-timetable branch from 85e133d to 365abdd Compare October 28, 2024 10:34

tomasr8 reviewed Oct 28, 2024

View reviewed changes

ThiefMaster reviewed Oct 28, 2024

View reviewed changes

indico/modules/events/timetable/templates/pdf/timetable.html Outdated Show resolved Hide resolved

tomasr8 reviewed Oct 29, 2024

View reviewed changes

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

indico/modules/events/timetable/templates/pdf/_toc.html Outdated Show resolved Hide resolved

AjobK force-pushed the pdf-timetable branch from d01a67d to a101505 Compare October 30, 2024 13:49

AjobK requested review from ThiefMaster and tomasr8 October 31, 2024 10:59

ThiefMaster reviewed Oct 31, 2024

View reviewed changes

indico/modules/events/timetable/controllers/display.py Outdated Show resolved Hide resolved

AjobK requested a review from ThiefMaster November 1, 2024 08:57

AjobK force-pushed the pdf-timetable branch from 4bd50a5 to 3c5df12 Compare November 1, 2024 13:28

tomasr8 reviewed Nov 6, 2024

View reviewed changes

ThiefMaster reviewed Nov 6, 2024

View reviewed changes

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

indico/modules/events/timetable/templates/pdf/_program.html Outdated Show resolved Hide resolved

AjobK force-pushed the pdf-timetable branch from 3c5df12 to 5481fb3 Compare November 6, 2024 13:35

tomasr8 force-pushed the pdf-timetable branch from 4811e1b to 7d37307 Compare November 13, 2024 15:51

AjobK and others added 26 commits December 12, 2024 10:36

removed accidental code fragment

a1e2134

fix typo

fb3b950

context comment

8c0828e

troun pr comments

5f1d49f

adrian comments

ad7f59c

rm current date from pdf

7ca9130

Remove unused current time

c12fab1

Add cover page for single-session timetable

25031a6

visual improvements to coverpage and added context to trans

3dc83b1

better iteration logic

050f8f2

Use new timetable PDF generation in static sites

3d4faf6

Get rid of legacy timetable PDF code

0a42d7d

Remove useless self-import and re-arrange function

aff8e3d

Avoid negation in option name

a9c181a

Disable poster abstracts in default PDFs

92d4b5e

This option feels way too noisy to be enabled there...

Deduplicate default PDF timetable code

b3d5deb

It was literally the same for static pages and the live endpoint

Set default settings in a central place

14b8d80

Remove weird blank line

c38149d

Deduplicate timetable PDF generation code

1465d58

Keep distinct filename for session timetable

dfdbe9e

Unify naming

56eb682

Fix linter error

41b0615

Add changelog entry

5e62718

Add missing access check to nested contributions

7964342

removed distinction between advanced and simple mode

93c1e28

rename multi checkbox headers

a7ded4b

ThiefMaster force-pushed the pdf-timetable branch from ea08998 to a7ded4b Compare December 12, 2024 09:36

ThiefMaster approved these changes Dec 12, 2024

View reviewed changes

ThiefMaster merged commit a2384cd into indico:master Dec 12, 2024
9 checks passed

Revamp and generate PDF timetable using Weasyprint #6558

Revamp and generate PDF timetable using Weasyprint #6558

Uh oh!

Conversation

AjobK commented Sep 23, 2024

Uh oh!

ThiefMaster left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AjobK commented Sep 24, 2024

Uh oh!

Uh oh!

AjobK commented Oct 25, 2024

Uh oh!

AjobK commented Oct 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AjobK commented Nov 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ThiefMaster left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants