Include file info in abstract JSON export #6556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
force-pushed
the
abstract-json-files
branch
from
2919abd to
1793f8d
Compare
tomasr8
reviewed
Sep 23, 2024
|
|
||
| class AbstractFileSchema(mm.SQLAlchemyAutoSchema): | ||
| icon = mm.Function(lambda af: icon_from_mimetype(af.content_type)) | ||
| download_url = mm.Function(lambda af: url_for('abstracts.download_attachment', af)) |
Member
There was a problem hiding this comment.
Would it make sense to use an external URL here?
Member
Author
There was a problem hiding this comment.
hm, we don't do so either for paper files... but yeah, might be nice to change it for all places where it's an export that's meant to be downloaded and not used in indico itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.