Improve country select accessibility #6551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
foxbunny
commented
Sep 19, 2024
foxbunny
commented
- Use the Select component for country list
- Adjust the styling for country dropdown to match the width of other dropdowns
foxbunny
force-pushed
the
country-combobox
branch
from
355ff64 to
3dadabb
Compare
Member
|
Since I don't think this is already part of the Select component: We need the search to ignore diacritics, similar to the code that was added e.g. in #6448. This could be applied to all dropdowns, so probably a good candidate to be added to the Select component itself (FWIW in SUI it's opt-in via the |
ThiefMaster
reviewed
Sep 19, 2024
tomasr8
approved these changes
Sep 19, 2024
- Use the Select component for country list - Adjust the styling for country dropdown to match the width of other dropdowns
Co-authored-by: Adrian <[email protected]>
That way searching for `_.` or similar in the code quickly finds all occurrences. It's also consistent with the rest of the codebase.
ThiefMaster
force-pushed
the
country-combobox
branch
from
e4565be to
2a3a1b5
Compare
ThiefMaster
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.