Skip to content

Conversation

@vtran99
Copy link
Contributor

@vtran99 vtran99 commented Sep 17, 2024

Request to add logs to action 'change of registration form settings'.

@ThiefMaster
Copy link
Member

Maybe we can use this opportunity to add proper diff logging to registration form setting changes?

I don't like the idea of hardcoding a single case here and not logging anything else...

So basically, do something similar to what we do in update_category / _log_category_update or _log_event_update.

@vtran99 vtran99 marked this pull request as draft September 17, 2024 14:17
@vtran99 vtran99 changed the title Add log for change of registration form private status Add logs for change of registration form settings Sep 18, 2024
@vtran99 vtran99 marked this pull request as ready for review September 18, 2024 14:48
@vtran99 vtran99 requested a review from ThiefMaster September 18, 2024 14:48
@ThiefMaster ThiefMaster force-pushed the Add_log_for_private_status_of_regform branch from b10b0b1 to ced43e3 Compare September 19, 2024 07:23
@vtran99
Copy link
Contributor Author

vtran99 commented Sep 19, 2024

I wonder if you hadn't make a mistake with the latest change for log title ?
Here are the 2 logs:
the upper is with your change, the 2nd is mine, and it seems easier to filter logs on Registration Form with the old code...
image

@ThiefMaster
Copy link
Member

Yes, it's consistent with the log messages for creation. The text there is the module, not the log subject (that's a mistake in my commit msg ;)). And if you view one of those messages, there is a button near the bottom of the modal to filter all log messages for that regform - so you see updates, creation, etc

@ThiefMaster ThiefMaster enabled auto-merge (squash) September 19, 2024 08:42
@ThiefMaster ThiefMaster added this to the v3.3 milestone Sep 19, 2024
@ThiefMaster ThiefMaster merged commit dcc04ee into indico:master Sep 19, 2024
@ThiefMaster ThiefMaster deleted the Add_log_for_private_status_of_regform branch September 19, 2024 08:48
vtran99 added a commit to UNOG-Indico/indico-core that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants