Skip to content

Conversation

@OmeGak
Copy link
Member

@OmeGak OmeGak commented Aug 24, 2024

No description provided.

@ThiefMaster
Copy link
Member

ThiefMaster commented Aug 26, 2024

As discussed on Matrix:

  • this should not check for key existence but rather non-falsy values
  • _validate_config after _postprocess_config would be a good place for this

Also, I'd consider these options required since things will be broken if they are missing:

SQLALCHEMY_DATABASE_URI
SECRET_KEY
BASE_URL

CELERY_BROKER
REDIS_CACHE_URL

DEFAULT_TIMEZONE
DEFAULT_LOCALE

CACHE_DIR
TEMP_DIR
LOG_DIR

STORAGE_BACKENDS
ATTACHMENT_STORAGE

SUPPORT_EMAIL  # error reports
NO_REPLY_EMAIL  # noreply sender

Some of them have decent defaults that work in a standard environment, but they are nonetheless required, so if someone set them to an empty string, None, etc., things would break.

@OmeGak OmeGak force-pushed the wip/required-keys branch 3 times, most recently from 1daa8bb to e60f848 Compare August 30, 2024 10:31
@OmeGak OmeGak changed the title WIP Warn missing required keys in indico.conf Warn about required keys in indico.conf Aug 30, 2024
@OmeGak OmeGak marked this pull request as ready for review August 30, 2024 10:31
@OmeGak OmeGak force-pushed the wip/required-keys branch from e60f848 to 1382459 Compare August 30, 2024 12:40
@ThiefMaster ThiefMaster added this to the v3.3 milestone Aug 30, 2024
@ThiefMaster ThiefMaster enabled auto-merge (squash) August 30, 2024 12:51
@ThiefMaster ThiefMaster merged commit f0071d4 into indico:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants