Keep comment when opening judgment form #6502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micsucmed
force-pushed
the
judge-button-comment
branch
from
9efd061 to
1b82bdc
Compare
tomasr8
reviewed
Aug 23, 2024
indico/modules/events/editing/client/js/editing/timeline/CommentForm.jsx
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
judge-button-comment
branch
from
a1f6d1f to
b390f5d
Compare
ThiefMaster
reviewed
Aug 26, 2024
indico/modules/events/editing/client/js/editing/timeline/CommentForm.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/editing/timeline/CommentForm.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/editing/timeline/ReviewForm.jsx
Outdated
Show resolved
Hide resolved
ThiefMaster
force-pushed
the
judge-button-comment
branch
from
b390f5d to
f5568cf
Compare
ThiefMaster
changed the title
tomasr8
reviewed
Aug 27, 2024
indico/modules/events/editing/client/js/editing/timeline/ReviewForm.jsx
Outdated
Show resolved
Hide resolved
Comment on lines
94
to
99
| setTimeout(() => { | ||
| onFocus(); | ||
| setValue(value); | ||
| onBlur(); | ||
| }); |
Member
There was a problem hiding this comment.
That's really dirty, but if that's what it takes to make final form work.. 😅
ThiefMaster
force-pushed
the
judge-button-comment
branch
from
f5568cf to
7f61cd6
Compare
ThiefMaster
reviewed
Sep 3, 2024
indico/modules/events/editing/client/js/editing/timeline/ReviewForm.jsx
Outdated
Show resolved
Hide resolved
Set state for text area value
Unfortunately final-form is kind of broken when it comes to setting an initial field value in a way that marks the field dirty, so we have to use this ugly workaround instead.
Make sure the submit (Judge) button is enabled when writing a comment and then switching e.g. to "Reject" mode with that pre-filled comment.
ThiefMaster
force-pushed
the
judge-button-comment
branch
from
221ba8c to
c17ffb4
Compare
ThiefMaster
force-pushed
the
judge-button-comment
branch
from
c17ffb4 to
5b3c28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When clicking on the comment box in the editing timeline, the "Judge" button disappears, creating confusion with some editors, who don't realize they have to cancel the comment before they get back the judgment button.
Solution
The Judge drop-down button will remain visible when commenting and preserve any written text when changing to a judge action.
closes #6503