Fix PictureField cropped until no image left #6498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbtwist
force-pushed
the
PictureFieldFix
branch
from
42985f5 to
8257cf8
Compare
jbtwist
changed the title
jbtwist
force-pushed
the
PictureFieldFix
branch
from
8257cf8 to
76245c6
Compare
ThiefMaster
force-pushed
the
PictureFieldFix
branch
from
76245c6 to
41ede3f
Compare
- use same range client/server side - send null instead of 0 in case of empty field All the logic that looks at this value already supports both `0` and `null`, so no need for migration that replaces `0` with `null` for existing fields.
ThiefMaster
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed via Element, there's a problem with cropping too much a picture in the registration form.
This PR solves the issue.