Split management/public registration file upload #6487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Aug 14, 2024
Contributor
Author
|
Hi Adrian, |
ThiefMaster
force-pushed
the
Fix-reg-file-upload
branch
from
a8016b4 to
efb2768
Compare
ThiefMaster
approved these changes
Aug 20, 2024
ThiefMaster
force-pushed
the
Fix-reg-file-upload
branch
from
efb2768 to
8b05a05
Compare
Member
|
I added some cleanups (e.g. not having registration-specific stuff in the files module) and fixed the missing split for the picture upload RH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request change to fix issue "Access denied" in private form when uploading file in registration from management area.
Tests done: upload file in front-end/back-end, with public and private form.
Notes:
I name the new RH for management similar to existing to be consistent, but in general the naming is a bit confusing to distinguish RH front/back-end.