Use hatchling instead of setuptools #6477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Member
|
Finally moving to |
ThiefMaster
force-pushed
the
hatchling
branch
3 times, most recently
from
e358a43 to
fb30f8f
Compare
ThiefMaster
force-pushed
the
hatchling
branch
2 times, most recently
from
9ee83fa to
0e28e4b
Compare
We skip *_test.py files when building wheels (or doing non-editable installs in general), but one such file was referenced by an "importable" fixture
We do not use nor publish sdists, but by using the standard build flow we get better build isolation, which is particularly useful in case of plugins that use setuptools, since we do not need to manually remove the `build` directory created during the wheel build process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setuptools is rather annoying when doing a PEP-660-style editable install by requiring code execution to map the package name to a path. This is not supported by static code analyzers such as the VSCode Python extension, so in case of such an installation any
indicoimports in plugins cannot be resolved.Hatchling uses a simple static
_indico.pthfile that points to the source directory, which does not have this problem.It's also overall nicer, e.g. by automatically excluding gitignored files instead of the (obscure)
MANIFEST.in