-
Notifications
You must be signed in to change notification settings - Fork 510
Many changes in VC code, to prepare for new Zoom Rooms plugin #6475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77ba80d to
9188def
Compare
tomasr8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left you some comments :) I'm not that familiar with the VC code so some of them might be off base..
6186ac3 to
6ca6296
Compare
879a74f to
007e455
Compare
007e455 to
3bb0553
Compare
3bb0553 to
a1945ed
Compare
b973009 to
b5b4111
Compare
|
Much nicer, even though the font size is pretty tiny... :/ |
2e138a5 to
ce9a181
Compare
Not much we can do, I'm afraid. It's consistent with the other buttons, right? TBH, I felt tempted to just get rid of the text altogether and leave only the icon. |
|
Maybe icon-only is not such a bad idea (but keeping visually hidden text for a11y so it's not really just an icon). |
Screencast.from.2024-10-31.12-17-38.webm |
ce9a181 to
af834eb
Compare
af834eb to
2b33281
Compare
Useful in unit tests
Otherwise the `cloned` signal might be called before there is a TimetableEntry
Co-authored-by: Adrian <[email protected]>
fd3f47e to
ed87162
Compare



I think this is finally ready for a first pair of extra eyes. I still have to go over it a bit more carefully, but having someone else look at it will help find any issues.
Main changes:
VCRoom.deletemethod which deals with the logic of deleting a whole room and its associationssession_updatedandsession_block_updatedto allow for achangesdict to be passedsplit_log_location_changesnon-destructive, since object mutation was messing with some testsUnrelated things which are bundled too:
PRs for the CERN and general-purpose plugins will follow.