Skip to content

Conversation

@bbb-user-de
Copy link
Contributor

@bbb-user-de bbb-user-de commented Aug 6, 2024

closes #6465

globe.png now as .webp, generated with cwebp (default settings)
@bbb-user-de bbb-user-de changed the title fixes #6465 close #6465 Aug 6, 2024
@bbb-user-de bbb-user-de closed this Aug 6, 2024
@bbb-user-de

This comment was marked as duplicate.

@bbb-user-de bbb-user-de reopened this Aug 6, 2024
@ThiefMaster ThiefMaster changed the title close #6465 Use smaller rb splash image Aug 6, 2024
Copy link
Member

@GovernmentPlates GovernmentPlates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Just one thing: the globe.png file should be removed as we are now using the .webp file.

globe.png is no longer needed
@bbb-user-de
Copy link
Contributor Author

you are right 👍😉

@tomasr8
Copy link
Member

tomasr8 commented Aug 6, 2024

Judging by the CI failure, we probably need to add the .webp format to our webpack config as well:

test: /\/static\/(images|fonts)\/.*\.(jpe?g|png|gif|svg|woff2?|ttf|eot)$/,

@ThiefMaster ThiefMaster added this to the v3.3 milestone Aug 7, 2024
@ThiefMaster ThiefMaster enabled auto-merge (squash) August 7, 2024 09:15
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, really useful!

@ThiefMaster ThiefMaster merged commit 22e81aa into indico:master Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change filetype for globe.png

4 participants