Implement DateRange picker #6464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxbunny
force-pushed
the
dual-calendar
branch
2 times, most recently
from
254705c to
c042ee8
Compare
Collaborator
Author
|
Changing to WIP. Figured out a more accessible way to represent the date grid. |
foxbunny
requested review from
ThiefMaster and
tomasr8
and removed request for
ThiefMaster
Member
|
I'd like to know what others think, but imo showing the same day in both calendars looks a bit confusing when you're selecting a range: |
Member
|
I agree, having those duplicates is quite weird. Even more so when you want to quickly count the number of days selected based on the highlighted fields... |
Collaborator
Author
|
Ok, I'll change that. |
tomasr8
reviewed
Aug 7, 2024
tomasr8
reviewed
Aug 7, 2024
foxbunny
force-pushed
the
dual-calendar
branch
2 times, most recently
from
e6b1043 to
af57de5
Compare
Member
|
Hey, could you please rebase this one? There are some conflicts w/ what I guess are changes from #6310. |
foxbunny
force-pushed
the
dual-calendar
branch
2 times, most recently
from
cafc3a8 to
09632f0
Compare
ThiefMaster
reviewed
Aug 22, 2024
foxbunny
force-pushed
the
dual-calendar
branch
from
fd46f6d to
261fb8c
Compare
ThiefMaster
reviewed
Aug 28, 2024
- Convert the Calendar*Picker components to use the DatePickerCalendar components - Add support for using <ind-calendar> inline without a dialog - Add simplified date selection strategy for inline usage - Add the ability to pause the preview in <ind-calendar>
- Create a new selection strategy for single date pickers - Create a separate custom element for non-range inline picker
- handle errors when value is null - correctly validate required field - mark field as touched when interacting with it
The `yearsAfter` in the old date picker was just so the dropdown did not show later years, but it was not a limit (it showed selected+1, not current+1).
ThiefMaster
force-pushed
the
dual-calendar
branch
from
ce996ed to
6bacc61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<ind-date-range-picker>element andDateRangePickercomponent (the new component is aliased asDateRangePicker2because the name is already taken)