Allow many CSV delimiters #6458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Jul 28, 2024
ThiefMaster
reviewed
Jul 28, 2024
indico/modules/events/registration/controllers/management/invitations.py
Outdated
Show resolved
Hide resolved
ThiefMaster
force-pushed
the
csv-separator
branch
from
25fd690 to
76d594c
Compare
Member
|
Do you plan to add the same functionality in all the other places where CSV files can be uploaded? |
Contributor
Author
|
Yes, I'll add the rest of the cases. |
Contributor
Author
|
@ThiefMaster still, I'd prefer do that in a separate PR, in order not to delay merging this one. |
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to specify the CSV delimiter when importing invitations to an event. Allowed values are:
Screenshots