Add support for Typescript code and React components #6456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
ThiefMaster
reviewed
Jul 26, 2024
pferreir
force-pushed
the
exp-typescript-support
branch
2 times, most recently
from
ee2eb94 to
32c9214
Compare
Member
|
One thing I noticed that doesn't work with Prettier is this TS syntax: import type {XXX} from yyy;Prettier reports a syntax error for this line. I think the fix is to just update our prettier version. Otherwise, everything else seems to be working well |
Member
"just" would be a case of "famous last words" considering the mess the new prettier versions are.. :/ so I'd say something to look into outside this PR |
Member
Sure, it's not a blocker anyway, normal imports should work just as well |
Member
Author
|
Anything else here? Can we merge this? |
Member
|
I'll have a look this afternoon :) |
ThiefMaster
force-pushed
the
exp-typescript-support
branch
from
32c9214 to
bcf54bd
Compare
Seems to work without as well, but don't ask me why. Feels cleaner to be explicit though as long as we specify something.
ThiefMaster
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, I think this is now ready to be merged. Type checking seems to work OK, but if someone could try it out, I'd be thankful.