Improve SessionsField friendly data #6431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Jul 4, 2024
tomasr8
reviewed
Jul 5, 2024
Member
tomasr8
left a comment
tomasr8
left a comment
There was a problem hiding this comment.
Should we also show the day when filtering by the sessions?
Contributor
Author
I think we should, specially when sessions have very similar names, it's way easier to distinguish them by day-hour than reading the entire title |
We use two-digit months everywhere else
ThiefMaster
force-pushed
the
friendly_data
branch
from
9e26e58 to
4b5f035
Compare
ThiefMaster
force-pushed
the
friendly_data
branch
from
4b5f035 to
762af33
Compare
ThiefMaster
approved these changes
Jul 11, 2024
Member
|
Oops, completely missed the comments here before merging it (but so did you when requesting the new review 2h ago :p). I added 4e08782 to also apply this to the filter dropdown. |
OmeGak
pushed a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 15, 2024
OmeGak
pushed a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At UN side we have realised there are parts where SessionsField data is not descriptive enough since, out of context, might be hard to identify sessions with similar names just by start hour, since the day it's unknown.
I have decided to add only the weekly day and month number to avoid generating a too large string, I feel this way is more than enough to identify sessions, but feedback is appreciated