Fix attaching large pictures in registration notification emails #6411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SegiNyn
force-pushed
the
limit-pic-size
branch
2 times, most recently
from
90a94fb to
ad59db1
Compare
ThiefMaster
reviewed
Jun 21, 2024
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
tomasr8
reviewed
Jun 21, 2024
ThiefMaster
reviewed
Jun 21, 2024
OmeGak
reviewed
Jun 24, 2024
ThiefMaster
reviewed
Jun 24, 2024
ThiefMaster
reviewed
Jun 24, 2024
indico/web/client/js/react/components/pictures/PictureManager.jsx
Outdated
Show resolved
Hide resolved
ThiefMaster
force-pushed
the
limit-pic-size
branch
from
6672b01 to
5b54f25
Compare
ThiefMaster
approved these changes
Jun 24, 2024
SegiNyn
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jun 24, 2024
- Resize to max 1000px (long edge) during upload - Always convert pictures to JPEG - Use 120px thumbnail in emails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ThiefMaster ,
This is to fix the issue we are facing sending registration notification emails due to the emails being too large from the attached pictures. @OmeGak told me that you proposed these 2: