Update pdfjs + switch webpack config to ESM #6389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
ThiefMaster
commented
Jun 12, 2024
Comment on lines
+161
to
+165
| // TODO remove after updating react: | ||
| fallback: { | ||
| 'react/jsx-runtime': 'react/jsx-runtime.js', | ||
| 'react/jsx-dev-runtime': 'react/jsx-dev-runtime.js', | ||
| }, |
Member
Author
There was a problem hiding this comment.
This is needed beacause React 17 does not have the proper ESM exports, but react-pdf imports react/jsx-runtime internally (they use the new-style jsx transform)
ThiefMaster
force-pushed
the
update-pdfjs
branch
from
acde331 to
f513e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.