Refactor ReviewForm #6375
Merged
Refactor ReviewForm #6375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
force-pushed
the
refactor-review-form
branch
3 times, most recently
from
0033c84 to
0fdebb1
Compare
duartegalvao
force-pushed
the
refactor-review-form
branch
from
3fb1c63 to
0fdebb1
Compare
ThiefMaster
force-pushed
the
refactor-review-form
branch
from
0fdebb1 to
5813ace
Compare
duartegalvao
force-pushed
the
refactor-review-form
branch
from
5813ace to
077e055
Compare
ThiefMaster
force-pushed
the
refactor-review-form
branch
from
ceb5583 to
5993a11
Compare
ThiefMaster
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ReviewForm component, and changes the behavior of "update and accept" onto an "accept with files"
Changes:
ReviewFormto include a globalFinalFormfor all actionsupdate_acceptaction entirelyDepends on #6374