Fix filter storage being shared between events #6359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
OBS: better to deploy after IPAC is done |
Member
|
Is that comment meant as a "no need to deploy this" or "don't break people's saved filters"? If it's the latter I won't merge it yet in case something else come up that we want to deploy right away. |
Member
Author
yep, the latter. either way you can probably merge it since editing is about to end and I don't think there's gonna be any more "emergency" deployments |
Member
Author
|
@ThiefMaster FYI all of the editing for IPAC is done, feel free to merge/deploy whenever |
ThiefMaster
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced in #6192 in which the editable list filter storage is shared between editable types and events.