Make avatar_url unguessable #6346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I did a few cleanups and also added mocking the serializer so the URLs do not change between test runs. |
ThiefMaster
force-pushed
the
Modify_avatar_url
branch
from
054d85c to
b86f148
Compare
ThiefMaster
approved these changes
May 17, 2024
ThiefMaster
force-pushed
the
Modify_avatar_url
branch
from
b86f148 to
92b60ff
Compare
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to modify avatar_url to make it unguessable as with the current '/user//picture-default'
it's too easy for anyone to access other user's profile picture by changing randomly number.
Notes:
This change breaks the tests on users as dataset used contain static value of 'avatar_url' which can't be set with the change.
What I can do is: