Allow documents to be generated from within the registration details #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitenvidhani
commented
Apr 19, 2024
indico/modules/events/registration/templates/management/_registration_details.html
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ThiefMaster Should I update |
ThiefMaster
reviewed
Apr 21, 2024
indico/modules/events/registration/templates/management/_registration_details.html
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Apr 22, 2024
indico/modules/events/registration/templates/management/_registration_details.html
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Apr 22, 2024
indico/modules/events/registration/templates/management/_registration_details.html
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Apr 22, 2024
indico/modules/events/registration/templates/management/_registration_details.html
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Apr 22, 2024
indico/modules/events/registration/templates/management/_registration_details.html
Outdated
Show resolved
Hide resolved
Member
|
I think the placement of the button is nice, but it looks really bad when there are no documents yet in a registration:
I suggest keeping the box title and showing a nice "There are no documents yet" message inside it. |
Contributor
Author
|
Fixed it @ThiefMaster |
Member
|
|
GovernmentPlates
force-pushed
the
document_in_profile
branch
2 times, most recently
from
f7a69ee to
a895e85
Compare
GovernmentPlates
force-pushed
the
document_in_profile
branch
from
a895e85 to
1c5df53
Compare
ThiefMaster
force-pushed
the
document_in_profile
branch
from
144349b to
d686ed6
Compare
ThiefMaster
approved these changes
Jun 14, 2024
GovernmentPlates
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.