Skip to content

Conversation

@maxnoe
Copy link
Contributor

@maxnoe maxnoe commented Apr 4, 2024

closes #6272

@ThiefMaster ThiefMaster linked an issue Apr 4, 2024 that may be closed by this pull request
@ThiefMaster
Copy link
Member

I recommend not putting the issue reference in the commit message itself but only in the PR description. Otherwise it spams one line of being referenced into the issue whenever you rebase and forcepush. Not a big problem but slightly noisy.

@maxnoe maxnoe force-pushed the remove_pkg_resources branch from f33743a to 1671c73 Compare April 4, 2024 10:13
@ThiefMaster
Copy link
Member

Please run isort indico and fix the linter error (see CI or ruff check and my other comment).

What do you think about using https://pypi.org/project/importlib-metadata/ instead of the stdlib one to avoid any nasty surprises with Python version updates? Or is the API of the stdlib version stable enough now? At least when I moved some of our libraries from setuptools to importlib.metadata, I got some nasty bugs when using the stdlib one on multiple Python versions, that were avoided with importlib-metadata. Of course Indico only supports 3.12 right now, but late this year when 3.13 comes out I plan to add support for it once all our dependencies are compatible, so we will once again be in a situation where differences between the stdlib one may be relevant.

@ThiefMaster ThiefMaster force-pushed the remove_pkg_resources branch from 1671c73 to cdaafe7 Compare April 16, 2024 17:49
`version` is REALLY REALLY generic...
@ThiefMaster ThiefMaster force-pushed the remove_pkg_resources branch from 11c89bb to 5f69146 Compare April 16, 2024 18:23
@ThiefMaster ThiefMaster force-pushed the remove_pkg_resources branch from d60719b to f2a9c77 Compare April 16, 2024 18:32
@ThiefMaster ThiefMaster enabled auto-merge (squash) April 16, 2024 18:33
@ThiefMaster ThiefMaster changed the title Replace pkg_resources with importlib, fixes #6272 Replace pkg_resources with importlib Apr 16, 2024
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works fine!

@ThiefMaster ThiefMaster merged commit ebd989b into indico:master Apr 16, 2024
@maxnoe maxnoe deleted the remove_pkg_resources branch April 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace pkg_resources with importlib.metadata / importlib.resource

2 participants