Add default receipt templates #6250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
at least on the screenshot the alignment of the button compared to the "Custom templates" header looks weird |
duartegalvao
commented
Mar 26, 2024
Member
Author
it's the same as before, but I can try to tweak it
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ThiefMaster
reviewed
Mar 26, 2024
indico/modules/receipts/default_templates/receipt/template.html
Outdated
Show resolved
Hide resolved
Member
|
nvm about the button if it looked crappy before. thought it was something new |
ThiefMaster
reviewed
Mar 26, 2024
indico/modules/receipts/client/js/templates/TemplateListPane.jsx
Outdated
Show resolved
Hide resolved
duartegalvao
force-pushed
the
default-templates
branch
from
09164d5 to
97bfb51
Compare
duartegalvao
force-pushed
the
default-templates
branch
from
97bfb51 to
5dd5c32
Compare
duartegalvao
force-pushed
the
default-templates
branch
from
5dd5c32 to
e0a6b1c
Compare
duartegalvao
force-pushed
the
default-templates
branch
2 times, most recently
from
c96941f to
4a211b3
Compare
ThiefMaster
reviewed
Mar 28, 2024
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
This looks REALLY nice! And I was positively surprised when testing this since while writing the issue for this I thought about just cloning the default template when selecting it, but pre-filling the editor with it is actually much nicer!
indico/modules/receipts/client/js/templates/TemplateListPane.jsx
Outdated
Show resolved
Hide resolved
ThiefMaster
force-pushed
the
default-templates
branch
from
a68322a to
2376ef3
Compare
ThiefMaster
reviewed
Mar 28, 2024
ThiefMaster
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two default templates, which can be added to any event/category in the "Document Templates" mgmt page:
It also includes a util to dump a template from the DB onto the
default_templatesdirectory, which can be run as such:Closes #6246