Avoid spoofing email senders #6231
Conversation
SegiNyn
changed the title
|
Is it really necessary to change the APIs internally? At least what I had in mind was simply changing the logic in the emails module to determine how to use From and Reply-to and only changing the form label in the various other places...
|
I saw that you already had a function _rewrite_sender that makes changes to the From address that's why I removed that and added a new function. And I thought it was better to make the changes before creating the EmailMessage. Also, to be sure where in the emails module did you have in mind? |
|
The changes to the names to sender_address instead of from_address isn't actually necessary but it makes it obvious to developers as well not just the users as is the case if only the label is changed. |
SegiNyn
force-pushed
the
add-email-sender
branch
from
1efc951 to
d0d8f70
Compare
ThiefMaster
force-pushed
the
add-email-sender
branch
from
d0d8f70 to
3737638
Compare
ThiefMaster
changed the title
|
Just FYI, I plan to merge this end of next week, shortly before we're going to put this in production at CERN. |
ThiefMaster
force-pushed
the
add-email-sender
branch
from
60beadb to
52f9e88
Compare
- prefer putting the email in the name part instead of just indico in cases where no name is available - avoid storing full emails with names in the database; instead lookup the name when the email address is used for sending an email - refactor logic to generate the real sender address, and also handle reply-to address in the same place - update documentation
ThiefMaster
force-pushed
the
add-email-sender
branch
from
55924d8 to
07f00f1
Compare
ThiefMaster
force-pushed
the
add-email-sender
branch
from
07f00f1 to
fedc796
Compare
Co-authored-by: Adrian Moennich <[email protected]>
Co-authored-by: Adrian Moennich <[email protected]>
Co-authored-by: Adrian Moennich <[email protected]>
Co-authored-by: Adrian Moennich <[email protected]>
3 participants
No description provided.