Add display picture in participant list #6228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm getting this error when viewing the participant list: File "/home/troun/dev/indico/indico/modules/events/registration/controllers/display.py", line 230, in _process
tables = [self._merged_participant_list_table()]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/troun/dev/indico/indico/modules/events/registration/controllers/display.py", line 162, in _merged_participant_list_table
registrations = sorted(_deduplicate_reg_data(_process_registration(reg, column_names)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/troun/dev/indico/indico/modules/events/registration/controllers/display.py", line 144, in _deduplicate_reg_data
for reg_data in reg_data_iter:
File "/home/troun/dev/indico/indico/modules/events/registration/controllers/display.py", line 162, in <genexpr>
registrations = sorted(_deduplicate_reg_data(_process_registration(reg, column_names)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/troun/dev/indico/indico/modules/events/registration/controllers/display.py", line 139, in _process_registration
columns.append({'text': self._picture_url(reg), 'is_picture': True})
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/troun/dev/indico/indico/modules/events/registration/controllers/display.py", line 129, in _picture_url
if reg.picture_data:
^^^^^^^^^^^^^^^^^
AttributeError: 'Registration' object has no attribute 'picture_data'There's no |
ThiefMaster
force-pushed
the
Add_picture_to_participant_list
branch
from
096c540 to
88c374e
Compare
Member
|
I rebased it and fixed the bugs with which testing this PR was impossible. |
Member
|
Please add a changelog entry: - Add the option to include the picture of a registration in the conference participant list
(:pr:`6228`, thanks :user:`vtran99`) |
ThiefMaster
reviewed
Mar 18, 2024
ThiefMaster
reviewed
Mar 18, 2024
vtran99
force-pushed
the
Add_picture_to_participant_list
branch
from
3da74de to
ff1f557
Compare
Contributor
Author
|
I updated the code following your comments( fix display position, manage case other pictures, optimise query, add change log) and merged in new commit. |
ThiefMaster
reviewed
Mar 25, 2024
ThiefMaster
force-pushed
the
Add_picture_to_participant_list
branch
3 times, most recently
from
99f7f59 to
138908d
Compare
- Move changelog to correct version - Do not generate image URL when there is no image - Do not render img with empty src - Make Forbidden errors more verbose - Fail nicely when there is no picture - Exclude image columns from sorting
ThiefMaster
force-pushed
the
Add_picture_to_participant_list
branch
from
138908d to
48f11b1
Compare
ThiefMaster
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to add the display of picture in Participant List, which is currently missing.