Fix double popup on overflown affiliations #6201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Feb 26, 2024
duartegalvao
force-pushed
the
fix-affiliation-popups
branch
from
780073d to
3c823b8
Compare
ThiefMaster
approved these changes
Feb 26, 2024
Member
|
Is this the weird bug @t4nec0 encountered but none of us were able to reproduce before? Good job in tracking it down! |
Member
Author
yep exactly! I finally managed to reproduce it, I didn't realize at first that it only happened when the affiliations were truncated... after that it was easy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in which two affiliation popups are shown in the Participant Roles when an affiliation link is used and the text overflows the cell:
This was caused by some jQuery code that creates the tooltips for overflown text. Unfortunately, the
.text()method also returns any scripts inside, resulting in the tooltip above. These are now disabled for all affiliation links.