Filter editable list by tags #6197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm getting this error in my console:
Most likely because of the |
ThiefMaster
reviewed
Feb 22, 2024
tomasr8
reviewed
Feb 22, 2024
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
editable-tag-filter
branch
from
ccb11ab to
12b9abb
Compare
Member
|
changelog pls :) |
ThiefMaster
reviewed
Feb 28, 2024
micsucmed
force-pushed
the
editable-tag-filter
branch
3 times, most recently
from
35a9ee6 to
206f407
Compare
micsucmed
force-pushed
the
editable-tag-filter
branch
from
206f407 to
356b639
Compare
Fix shallow comparison
ThiefMaster
force-pushed
the
editable-tag-filter
branch
from
356b639 to
8a76c84
Compare
Also make the filter do something (an empty array in JS is not falsy)
ThiefMaster
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6195
Adds a filter for the tags related to the Editables of contributions based on the
codeof the tags