Add editable status 'Accepted by Submitter' #6186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
suggested changes
Feb 16, 2024
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
tomasr8
reviewed
Feb 19, 2024
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
tomasr8
reviewed
Mar 20, 2024
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
micsucmed
force-pushed
the
editable-submission-status
branch
from
00bf1b9 to
c002efc
Compare
Member
|
can you please give the PR a more meaningful title? :) |
micsucmed
changed the title
micsucmed
force-pushed
the
editable-submission-status
branch
2 times, most recently
from
c4d3a49 to
793a1d3
Compare
ThiefMaster
reviewed
Dec 3, 2024
micsucmed
force-pushed
the
editable-submission-status
branch
from
4f40ab7 to
5a01c28
Compare
ThiefMaster
force-pushed
the
editable-submission-status
branch
from
5a01c28 to
0588035
Compare
The util was quite misleading since a revision was passed to it, but it then got the latest revision with files from the editable, which at that point was not yet flushed to the database. So doing a "request approval" review on a revision that initially did not have publishable files but adding them in that same revision was not possible.
ThiefMaster
force-pushed
the
editable-submission-status
branch
from
ad3f23f to
ad4f4e7
Compare
ThiefMaster
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6185