-
Notifications
You must be signed in to change notification settings - Fork 510
Calendar: filter by room #6158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar: filter by room #6158
Conversation
31d1309 to
16a0784
Compare
efe7ccd to
473b13e
Compare
|
@ThiefMaster ready for review 😎 |
ThiefMaster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have not really looked at the logic yet, this is just the one thing that i immediately noticed which could be shortened a bit
832c493 to
0915f74
Compare
|
Rebased to the lastest master branch. |
|
I'd add the two issues and this PR to the relevant changelog entries added in the last PR, and adjust the wording there if needed |
0915f74 to
bc5f4ff
Compare
Agreed. Just applied the changes. |
Done in f3424a5. |
indico/modules/categories/client/js/components/CalendarLegend.jsx
Outdated
Show resolved
Hide resolved
indico/modules/categories/client/js/components/CalendarLegend.jsx
Outdated
Show resolved
Hide resolved
f44d2e9 to
7a4a361
Compare
Both of them fixed.
The triangle was used initially just to visually align different elements. Ideally in a second iteration we planned to allow collapsing elements. |
84a65b7 to
9cae7ae
Compare
a26c467 to
fb039d0
Compare


Closes #6148
Closes #6149
This PR adds the following:
Screenshots