Include comment on email notifications for update and accept editing #6154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
approved these changes
Jan 31, 2024
Member
duartegalvao
left a comment
duartegalvao
left a comment
There was a problem hiding this comment.
LGTM, as I just said, maybe reference it on the changelog but not super important. good job!
micsucmed
force-pushed
the
timeline-message-notifications-updated-and-accept
branch
from
3470ff7 to
f130039
Compare
micsucmed
deleted the
timeline-message-notifications-updated-and-accept
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating and accepting an editable, the notifications email for editors/authors was not including the comment made during the update. The acceptance revision was the one being passed to create the notification email, so the comment was not being included. Now the update revision is the one sent to create the notification email.