-
Notifications
You must be signed in to change notification settings - Fork 510
Customize survey link email #6144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize survey link email #6144
Conversation
fe4e003 to
803fc94
Compare
e2cb483 to
07577fb
Compare
| <div class="group"> | ||
| <div id="email-submission-container" class="i-button-wrapper" data-event-id="{{ event.id }}" | ||
| data-survey-id="{{ survey.id }}"> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right place for the button. It implies that you email people who already answered the survey and/or that the selection in the list below applies to what this button does. But it simply emails all the event participants!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a new action box item below "Survey is live" would be a good place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also get rid of the "Send links" dialog (which is using the old one) for private surveys now that we have a new one that can do the same? The only main change we'd need is adding an option to enter custom email addresses (and maybe making "send to event participants" just an option so you can choose either of the two).
But maybe this is more something for a separate PR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I also thought about replacing the other dialog, but doing it in another PR is probably better
|
Maybe the SurveyLinkPlaceholder could be changed similar to the |
c326182 to
19ce56a
Compare
19ce56a to
a87922b
Compare
indico/modules/events/persons/client/js/EmailSurveyParticipants.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/persons/client/js/EmailSurveyParticipants.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/persons/client/js/EmailSurveyParticipantsButton.jsx
Show resolved
Hide resolved
91d37a1 to
c772100
Compare
94ba84f to
52f9e26
Compare
8e23ca7 to
2fd62fc
Compare
indico/modules/events/surveys/client/js/EmailSurveyParticipants.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/surveys/client/js/EmailSurveyParticipants.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/surveys/client/js/EmailSurveyParticipantsButton.jsx
Outdated
Show resolved
Hide resolved
293598a to
9fffd67
Compare
tomasr8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have some minor suggestions :)
indico/modules/events/surveys/client/js/EmailSurveyParticipants.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/surveys/client/js/EmailSurveyParticipantsButton.jsx
Outdated
Show resolved
Hide resolved
ecaf8b9 to
ab2c597
Compare
Wrong metadata
Relocate files Relable action box
Set active survey conditionally
Add custom recipients email list
Send emails to custom recipients email list
Simplify with walrus operator
ab2c597 to
17fabdf
Compare
closes #6069