Skip to content

Conversation

@micsucmed
Copy link
Contributor

closes #6069

@micsucmed micsucmed force-pushed the customize-survey-link-email branch from fe4e003 to 803fc94 Compare January 23, 2024 13:50
@micsucmed micsucmed force-pushed the customize-survey-link-email branch from e2cb483 to 07577fb Compare January 30, 2024 13:18
@micsucmed micsucmed marked this pull request as ready for review January 30, 2024 13:25
Comment on lines 109 to 113
<div class="group">
<div id="email-submission-container" class="i-button-wrapper" data-event-id="{{ event.id }}"
data-survey-id="{{ survey.id }}">
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right place for the button. It implies that you email people who already answered the survey and/or that the selection in the list below applies to what this button does. But it simply emails all the event participants!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a new action box item below "Survey is live" would be a good place?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also get rid of the "Send links" dialog (which is using the old one) for private surveys now that we have a new one that can do the same? The only main change we'd need is adding an option to enter custom email addresses (and maybe making "send to event participants" just an option so you can choose either of the two).

But maybe this is more something for a separate PR...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I also thought about replacing the other dialog, but doing it in another PR is probably better

@ThiefMaster
Copy link
Member

Maybe the SurveyLinkPlaceholder could be changed similar to the EventLinkPlaceholder so it allows setting a custom link text as well?

@micsucmed micsucmed force-pushed the customize-survey-link-email branch 2 times, most recently from c326182 to 19ce56a Compare February 5, 2024 13:31
@micsucmed micsucmed force-pushed the customize-survey-link-email branch from 19ce56a to a87922b Compare February 15, 2024 11:14
@micsucmed micsucmed force-pushed the customize-survey-link-email branch from 91d37a1 to c772100 Compare February 27, 2024 14:22
@ThiefMaster ThiefMaster force-pushed the customize-survey-link-email branch 2 times, most recently from 94ba84f to 52f9e26 Compare March 5, 2024 19:18
@micsucmed micsucmed force-pushed the customize-survey-link-email branch from 8e23ca7 to 2fd62fc Compare March 12, 2024 16:27
@micsucmed micsucmed force-pushed the customize-survey-link-email branch from 293598a to 9fffd67 Compare March 19, 2024 13:24
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have some minor suggestions :)

@micsucmed micsucmed force-pushed the customize-survey-link-email branch 2 times, most recently from ecaf8b9 to ab2c597 Compare March 22, 2024 15:43
@ThiefMaster ThiefMaster force-pushed the customize-survey-link-email branch from ab2c597 to 17fabdf Compare April 23, 2024 12:11
@ThiefMaster ThiefMaster enabled auto-merge (squash) April 23, 2024 15:42
@ThiefMaster ThiefMaster added this to the v3.3 milestone Apr 23, 2024
@ThiefMaster ThiefMaster merged commit 3735a27 into indico:master Apr 23, 2024
@micsucmed micsucmed deleted the customize-survey-link-email branch May 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to customise Survey Link Email

3 participants