Skip to content

Conversation

@duartegalvao
Copy link
Member

@duartegalvao duartegalvao commented Jan 18, 2024

This PR adds an option for managers to change the registration fee of a set of registrations in bulk.
image
image

Closes #6132

@ThiefMaster
Copy link
Member

I'd show the currency in the dialog. Maybe also indicate the currently configured base price of the regform or even pre-fill the field with that?

@duartegalvao duartegalvao force-pushed the edit-reg-fee branch 2 times, most recently from fb8e620 to 7d85cd0 Compare January 18, 2024 15:08
@duartegalvao
Copy link
Member Author

I'd show the currency in the dialog. Maybe also indicate the currently configured base price of the regform or even pre-fill the field with that?

image

Is it fine like this? (trying to avoid creating a whole template just for this form...)

@ThiefMaster
Copy link
Member

Yeah, fine for me.

I'd call it "Update" and not "Edit" btw (in the title).

@duartegalvao duartegalvao marked this pull request as ready for review January 19, 2024 10:28
@duartegalvao duartegalvao marked this pull request as draft January 19, 2024 10:33
@duartegalvao duartegalvao force-pushed the edit-reg-fee branch 3 times, most recently from d691232 to e243344 Compare January 23, 2024 10:55
@duartegalvao duartegalvao marked this pull request as ready for review January 26, 2024 09:28
@duartegalvao duartegalvao force-pushed the edit-reg-fee branch 2 times, most recently from c2391e0 to 4fff1dd Compare January 26, 2024 14:07
@ThiefMaster
Copy link
Member

Works really well! Just a minor thing that could maybe be improved: Currently changing the price to the current price will still show up as "successful" and be included in the log. I'm absolutely fine with considering it a success, but I don't think those should be included in the log entry (since nothing changed)

@duartegalvao
Copy link
Member Author

Works really well! Just a minor thing that could maybe be improved: Currently changing the price to the current price will still show up as "successful" and be included in the log. I'm absolutely fine with considering it a success, but I don't think those should be included in the log entry (since nothing changed)

Yeah I agree. Also, I noticed I'm not logging the state changes here, so I will also add that. It's probably best as a separate entry, since i dont see how to integrate both

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option for managers to edit base_price of a Registration

3 participants