-
Notifications
You must be signed in to change notification settings - Fork 510
Add ability to edit registrations' base_price #6138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd show the currency in the dialog. Maybe also indicate the currently configured base price of the regform or even pre-fill the field with that? |
fb8e620 to
7d85cd0
Compare
|
Yeah, fine for me. I'd call it "Update" and not "Edit" btw (in the title). |
7d85cd0 to
7bda209
Compare
indico/modules/events/registration/controllers/management/reglists.py
Outdated
Show resolved
Hide resolved
d691232 to
e243344
Compare
e243344 to
86730dc
Compare
c2391e0 to
4fff1dd
Compare
indico/modules/events/registration/controllers/management/reglists.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/reglists.py
Outdated
Show resolved
Hide resolved
fedfc6b to
2d1fc30
Compare
indico/modules/events/registration/controllers/management/reglists_test.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/reglists_test.py
Outdated
Show resolved
Hide resolved
2d1fc30 to
8c9792c
Compare
|
Works really well! Just a minor thing that could maybe be improved: Currently changing the price to the current price will still show up as "successful" and be included in the log. I'm absolutely fine with considering it a success, but I don't think those should be included in the log entry (since nothing changed) |
Yeah I agree. Also, I noticed I'm not logging the state changes here, so I will also add that. It's probably best as a separate entry, since i dont see how to integrate both |
8c9792c to
360fa32
Compare
ThiefMaster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly now
3a9cb90 to
65ac756
Compare
65ac756 to
0b309bd
Compare
0b309bd to
9b0c28b
Compare
9b0c28b to
ed8d2e4
Compare

This PR adds an option for managers to change the registration fee of a set of registrations in bulk.


Closes #6132