Allow linking badge templates to regforms #6088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
For double-sided:
|
ThiefMaster
reviewed
Dec 8, 2023
Contributor
|
Looks promising, if ready I can also try to review it in detail. |
tomasr8
force-pushed
the
designer-link-regform
branch
from
6bae113 to
4a999d2
Compare
Member
Author
Hi! Yes, definitely feel free to give it a try :) It should be more or less working at this point, I mostly need to add tests. |
tomasr8
changed the title
tomasr8
force-pushed
the
designer-link-regform
branch
2 times, most recently
from
133ec3d to
6ed84fd
Compare
ThiefMaster
reviewed
Jan 25, 2024
tomasr8
commented
Jan 31, 2024
tomasr8
force-pushed
the
designer-link-regform
branch
3 times, most recently
from
e0dddb3 to
6755199
Compare
ThiefMaster
force-pushed
the
designer-link-regform
branch
from
3021be1 to
38fceca
Compare
ThiefMaster
reviewed
Mar 1, 2024
ThiefMaster
force-pushed
the
designer-link-regform
branch
2 times, most recently
from
892573f to
87a693d
Compare
tomasr8
force-pushed
the
designer-link-regform
branch
from
ef7d31c to
f7f243f
Compare
tomasr8
commented
Mar 15, 2024
.../migrations/versions/20240314_1430_4e32f4d5ebe4_add_registration_id_to_designer_templates.py
Show resolved
Hide resolved
tomasr8
force-pushed
the
designer-link-regform
branch
from
06bd397 to
01b665c
Compare
ThiefMaster
reviewed
Mar 15, 2024
ThiefMaster
reviewed
Mar 15, 2024
tomasr8
force-pushed
the
designer-link-regform
branch
2 times, most recently
from
92f6017 to
e01d085
Compare
Co-authored-by: Adrian <[email protected]>
Co-authored-by: Adrian <[email protected]>
Co-authored-by: Adrian <[email protected]>
tomasr8
force-pushed
the
designer-link-regform
branch
from
e01d085 to
1a256f0
Compare
ThiefMaster
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that has been asked many times before is the ability to reference regform fields in the badge designer.
Currently you can use any regform as a source when printing badges and the list of available placeholders is limited to personal data since every regform has them.
The idea is to essentially allow linking templates to a specific regform. Once linked, you would be able reference any field from the linked regform.
Once linked, you have all registration data placeholders available in the badge designer and you can print the badges.
When printing badges/tickets, you can only select the linked regform (if any). The equivalent is true when configuring default ticket template in regforms (TicketsForm) - you can only select unlinked templates, or templates which are linked to the given regform.
This is what the UI for linking looks like currently:
For not currently linked templates, there is a 'plus' icon which opens dropdown where you can select to link a regform (same as when printing badges). To unlink, you click on the red 'X'.