-
Notifications
You must be signed in to change notification settings - Fork 510
Improve receipts module #6078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve receipts module #6078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
902462b to
d8b5662
Compare
d8b5662 to
546d700
Compare
546d700 to
d95d818
Compare
- Do not pass database objects to the context under any circumstances (this was big security hole, even for an admin-only feature, as it allowed manipulating pretty much any data in the DB) - Use the same schema for real data and preview data to avoid going out of sync (and generate the dummy data from a real event with all regform field types so people can see the data without digging through the code) - Add Python syntax highlighting for placeholders (since they are used in a Python context and not as JSON) - Indicate datetime objects instead of just showing them as an isoformat date string - Correctly display HTML from undefined objects and also apply Undefined logic to simply trying to display a top-level undefined value
bf4efaa to
e903b75
Compare
For large events rendering hundreds of receipts just for a preview would be way too slow
e903b75 to
e8ad623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.