Skip to content

Conversation

@ThiefMaster
Copy link
Member

No description provided.

- Do not pass database objects to the context under any circumstances
  (this was big security hole, even for an admin-only feature, as it
  allowed manipulating pretty much any data in the DB)
- Use the same schema for real data and preview data to avoid going out
  of sync (and generate the dummy data from a real event with all
  regform field types so people can see the data without digging through
  the code)
- Add Python syntax highlighting for placeholders (since they are used
  in a Python context and not as JSON)
- Indicate datetime objects instead of just showing them as an
  isoformat date string
- Correctly display HTML from undefined objects and also apply Undefined
  logic to simply trying to display a top-level undefined value
@ThiefMaster ThiefMaster force-pushed the receipts-fixes branch 2 times, most recently from bf4efaa to e903b75 Compare December 3, 2023 19:22
@ThiefMaster ThiefMaster marked this pull request as ready for review December 3, 2023 22:01
@ThiefMaster ThiefMaster enabled auto-merge (squash) December 3, 2023 22:03
@ThiefMaster ThiefMaster merged commit 9856c1f into indico:master Dec 3, 2023
@ThiefMaster ThiefMaster deleted the receipts-fixes branch December 3, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant