Only allow blocking ticket templates via is_ticket_blocked
#6062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Nov 24, 2023
tomasr8
force-pushed
the
ticket-blocked
branch
from
e657ac0 to
2cbad43
Compare
ThiefMaster
reviewed
Nov 27, 2023
tomasr8
force-pushed
the
ticket-blocked
branch
from
d380346 to
5530ecf
Compare
ThiefMaster
reviewed
Nov 30, 2023
indico/modules/events/registration/controllers/management/reglists.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/reglists.py
Outdated
Show resolved
Hide resolved
Currently plugins can block non-ticket templates (templates that do not contain a ticket QR code) via the 'is_ticket_blocked' signal. This change only allows blocking templates which contain a QR code.
Co-authored-by: Adrian <[email protected]>
tomasr8
force-pushed
the
ticket-blocked
branch
from
89f3ec5 to
0b1f61a
Compare
ThiefMaster
approved these changes
Dec 1, 2023
ThiefMaster
reviewed
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently plugins can block non-ticket templates (templates that do not contain a ticket QR code) via the 'is_ticket_blocked' signal.
This change only allows blocking templates which contain a QR code.
This is a followup fix to a SNOW ticket. There was an event with an active CERN access request which was preventing the organizers from sending a custom ticket (which did not contain a QR code) to the participants. The plugin was setting
is_ticket_blockedand on the Indico side we were not distinguishing ticket and non-ticket templates.