Add participant list preview #6052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Dec 4, 2023
indico/modules/events/registration/templates/management/regform_list.html
Outdated
Show resolved
Hide resolved
tomasr8
reviewed
Dec 4, 2023
indico/modules/events/registration/templates/display/participant_list.html
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/templates/display/participant_list.html
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/templates/display/participant_list.html
Outdated
Show resolved
Hide resolved
Member
|
@vtran99 Could you please rebase the PR? |
vtran99
force-pushed
the
Add_participantlist_preview
branch
from
2694d52 to
c28361f
Compare
Contributor
Author
Done (sorry). |
Contributor
Author
|
I just added a new commit to handle the case where event has more than one regform and user is registered only in one: |
vtran99
force-pushed
the
Add_participantlist_preview
branch
from
8c1e722 to
f82a052
Compare
Contributor
Author
|
Hello, |
ThiefMaster
force-pushed
the
Add_participantlist_preview
branch
4 times, most recently
from
1bbb828 to
4507280
Compare
ThiefMaster
approved these changes
Jun 20, 2024
ThiefMaster
changed the title
- use mixin + "standard" inheritance instead of inheriting management RH from display RH - remove overridable logic to check if preview is guest or participant view (not needed by UN guys in the end, always participant view is fine) - only show preview buttons in Conference events - use nicer title + add description text for the preview page
- not related to the functionality in this PR - not sure how a hybrid method works w/ interceptables
The current behavior is that you just need to be registered in some regform of the event to see the participant version of the participant list. Making this per-regform does not belong in here, there is another PR for it...
ThiefMaster
force-pushed
the
Add_participantlist_preview
branch
from
94d91bf to
2acf0ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to add action "Preview as participant" for managers on back-end.